Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol test clients generation #3247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Jan 14, 2025

Issue #, if available:
WIP for protocol tests for this SDK
Description of changes:

  1. Refactor python wrappers over code generators present on this SDK by extracting the logic into separate submodules for re-use and read-ability (I hope so).
  2. Add "protocol test clients" (sample clients for a fictional services used for test purposes) generation to the SDK.
    These clients should look, act, and behave just like any regular generated SDK client but are used for SDK testing only.

Tested by generating all and observing that no unexpected difference is generated.
The only difference is

$ python3 tools/scripts/run_code_generation.py --generate_protocol_tests
...
$ ls -a generated/protocol-tests/test-clients
aws-cpp-sdk-ec2-protocol
aws-cpp-sdk-json-protocol
aws-cpp-sdk-json-rpc-10
aws-cpp-sdk-query-protocol
aws-cpp-sdk-rest-json-protocol
aws-cpp-sdk-rest-xml-protocol
aws-cpp-sdk-rest-xml-protocol-namespace

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin changed the title [draft] Protocol test clients generation Protocol test clients generation Jan 15, 2025
@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review January 15, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants